Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc updates to better explain harvest server query format for subcollections #8197

Merged
merged 7 commits into from
Nov 1, 2021

Conversation

djbrooke
Copy link
Contributor

@djbrooke djbrooke commented Oct 28, 2021

What this PR does / why we need it:

Updating some docs to clarify how to create harvesting sets for subcollections

Which issue(s) this PR closes:

Closes IQSS/dataverse.harvard.edu#124

Special notes for your reviewer:

@jggautier edits very welcome!

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement over what's there but I added a comment about an easier way to find the Dataverse collection id.

doc/sphinx-guides/source/admin/harvestserver.rst Outdated Show resolved Hide resolved
@djbrooke djbrooke changed the title updates to make clearer the format for subcollections doc updates to better explain harvest server query format for subcollections Oct 28, 2021
Tried to clarify that the path should include all parent collections up to but excluding the Root collection.

Also added @pdurbin's suggestion of using an API endpoint to get the Dataverse collection's database ID. It might be helpful to link to the section of the API Guide that documents that endpoint, which I think is https://guides.dataverse.org/en/5.7/api/native-api.html?highlight=unlock#view-a-dataverse-collection, but I don't know the best way to do this in this rst file. Tried looking through this rst file to for an example but I'm still not sure. @pdurbin could you add a link behind ""View a Dataverse Collection" API endpoint"?
Small grammar edit.
@jggautier
Copy link
Contributor

I'm done with my smallish edits. I asked in a commit comment if @pdurbin could help add a link behind the API endpoint referenced in the revised text.

@pdurbin
Copy link
Member

pdurbin commented Oct 28, 2021

Sure, I added the link to the API Guide in 7b71433

Here's how it looks:

Screen Shot 2021-10-28 at 4 58 47 PM

Capitalizing another "ID"
@jggautier
Copy link
Contributor

Thanks! So it's :ref:`view-dataverse`

I'll try to remember that!

Is everyone here okay with the change? I am

@djbrooke
Copy link
Contributor Author

@jggautier @pdurbin thanks - looks good to me.

@pdurbin
Copy link
Member

pdurbin commented Oct 29, 2021

Thanks! So it's :ref:view-dataverse

I'll try to remember that!

Yeah, you have to add the ref on the other side if it doesn't exist already. refs are a nice way to link to a specific part on the page, especially necessary on long pages.

@djbrooke
Copy link
Contributor Author

@jggautier - this is in review and assigned to you, so if it's in a state where you feel OK with it, feel free to approve (after clicking "files changed" above) and unassign yourself. This'll move it over to QA. Thanks to you and @pdurbin for the edits!

From our edits to the section about the subtreePaths query, I copied the extra tip about using an API endpoint to get the database ID to the parentId query. That's the only other place, at least on this page, where the user needs to know what the database ID is and is given tips for how to get it.
@jggautier jggautier removed their assignment Oct 30, 2021
@kcondon kcondon self-assigned this Nov 1, 2021
@kcondon kcondon merged commit e8cfb50 into develop Nov 1, 2021
@kcondon kcondon deleted the 124-subcollection-harvest-docs branch November 1, 2021 15:05
@djbrooke djbrooke added this to the 5.8 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create harvesting set of datasets in "Original Murray Collection"
4 participants